----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51643/#review147973 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1537 - 1538) <https://reviews.apache.org/r/51643/#comment215279> I would mention that this step is necessary because we change the hostname to be containerID and libprocess (executor uses) needs to resolve that hostname. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1539 - 1540) <https://reviews.apache.org/r/51643/#comment215280> `hence it is fine` is not quite right. We polute the host filesystem. I think we should say that touch those files if they don't exist is fine. We only see that on CoreOS. - Jie Yu On Sept. 6, 2016, 9:09 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51643/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 9:09 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-6052 > https://issues.apache.org/jira/browse/MESOS-6052 > > > Repository: mesos > > > Description > ------- > > In case /etc/hosts and /etc/hostname files are not present in the host > filesystem, we were ignoring these files and assuming that they would > not be required by the executor when it is launched in a new network > namespace. This assumption is incorrect, since the executor needs > /etc/hosts in the new network namespace to resolve its hostname. > Hence, we are explicitly creating these files in the host file system > in case they are not present, so that containers /etc/hosts and > /etc/hostname can be mounted on these mount points. This solves the > problem in distributions such as CoreOS that don't have /etc/hosts in > their host filesystem. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > d17a45fe17bb74cbf9ae421dc8a492e5dc5f1a00 > > Diff: https://reviews.apache.org/r/51643/diff/ > > > Testing > ------- > > make check > > Also, build an open DC/OS image with this patch to run on CoreOS and tried > launch a unified containerizer through Marathon using dcos-cli to test this > patch on CoreOS. > > > Thanks, > > Avinash sridharan > >
