----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/#review147738 -----------------------------------------------------------
src/tests/containerizer/provisioner_appc_tests.cpp (lines 372 - 373) <https://reviews.apache.org/r/51420/#comment214960> Just nit, I saw that the recover case is using `UUID::random().toString()` to set the id while some using hard code ids, it is better make them consistent in code. src/tests/containerizer/provisioner_appc_tests.cpp (line 381) <https://reviews.apache.org/r/51420/#comment214958> s/string/const string src/tests/containerizer/provisioner_appc_tests.cpp (line 383) <https://reviews.apache.org/r/51420/#comment214957> s/string/const string src/tests/containerizer/provisioner_appc_tests.cpp (lines 383 - 386) <https://reviews.apache.org/r/51420/#comment214963> What about moving this to the end of the test just before when it was used before #404? - Guangya Liu On 八月 29, 2016, 9:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51420/ > ----------------------------------------------------------- > > (Updated 八月 29, 2016, 9:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Added provisioner appc unit test for provisioning nested container. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp > b3ba176e506a6d1528290c07a8a0555b12c8cf70 > > Diff: https://reviews.apache.org/r/51420/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
