----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/#review147553 -----------------------------------------------------------
support/mesos-tidy.sh (line 22) <https://reviews.apache.org/r/51525/#comment214739> ``` - CHECKS=${CHECK:-'-*,mesos-*'} + CHECKS=${CHECKS:-'-*,mesos-*'} ``` support/mesos-tidy.sh (line 23) <https://reviews.apache.org/r/51525/#comment214747> Maybe leave a comment on why we default to `--enable-optimize` support/mesos-tidy.sh (line 29) <https://reviews.apache.org/r/51525/#comment214738> "Please commit or stash any changes before running `mesos-tidy`!." support/mesos-tidy.sh (lines 34 - 39) <https://reviews.apache.org/r/51525/#comment214740> ``` docker run \ --rm \ -v "${MESOS_DIRECTORY}":/SRC \ -e CHECKS="${CHECKS}" \ -e CONFIGURE_FLAGS="${CONFIGURE_FLAGS}" \ mesosphere/mesos-tidy || exit 1 ``` support/mesos-tidy/Dockerfile (line 29) <https://reviews.apache.org/r/51525/#comment214741> Can this go right after `MAINTAINER`? support/mesos-tidy/Dockerfile (lines 35 - 37) <https://reviews.apache.org/r/51525/#comment214746> Can we try to get rid of this `sslVerify` stuff? support/mesos-tidy/Dockerfile (line 49) <https://reviews.apache.org/r/51525/#comment214742> Newline after this? support/mesos-tidy/README.md (line 9) <https://reviews.apache.org/r/51525/#comment214744> Backticks around `mesos-tidy`. support/mesos-tidy/entrypoint.sh (line 26) <https://reviews.apache.org/r/51525/#comment214745> Do we not need to do ``` CONFIGURE_FLAGS=${CONFIGURE_FLAGS:-''} ``` similar to what we do for `CHECKS` below? If we don't, it seems to me like we wouldn't need the ``` CHECKS=${CHECKS:-''} ``` either. support/mesos-tidy/entrypoint.sh (line 29) <https://reviews.apache.org/r/51525/#comment214743> This is my bad. ``` - bear make tests -j $(nproc) || exit 1 + bear make -j $(nproc) tests || exit 1 ``` - Michael Park On Sept. 1, 2016, 10:49 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51525/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 10:49 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4907 > https://issues.apache.org/jira/browse/MESOS-4907 > > > Repository: mesos > > > Description > ------- > > This commits adds tooling to both build and execute Mesos-specific > clang-tidy checks. We use a docker container for the execution, and > also provide a script to further streamline the tooling. > > > Diffs > ----- > > support/mesos-tidy.sh PRE-CREATION > support/mesos-tidy/Dockerfile PRE-CREATION > support/mesos-tidy/README.md PRE-CREATION > support/mesos-tidy/entrypoint.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/51525/diff/ > > > Testing > ------- > > The image used in `support/mesos-tidy.sh` is available on dockerhub, and > running that script does produce diagnostics. > > > Thanks, > > Benjamin Bannier > >
