----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/#review146896 -----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (lines 215 - 218) <https://reviews.apache.org/r/51405/#comment213687> Can you call CreateSlaveFlags instead? src/tests/containerizer/mesos_containerizer_tests.cpp (line 142) <https://reviews.apache.org/r/51405/#comment213688> I'd suggest we make MesosContainerizerIsolatorPreparationTest inherit from MesosTest and use CreateSlaveFlags src/tests/containerizer/mesos_containerizer_tests.cpp (lines 449 - 460) <https://reviews.apache.org/r/51405/#comment213689> Ditto. - Jie Yu On Aug. 25, 2016, 11:28 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51405/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 11:28 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6050 > https://issues.apache.org/jira/browse/MESOS-6050 > > > Repository: mesos > > > Description > ------- > > Updated a few more tests to create a temporary 'runtime_dir'. > > > Diffs > ----- > > src/tests/containerizer/isolator_tests.cpp > 2725eb0f76f4e2668381c0d6686a99649f4f9f25 > src/tests/containerizer/mesos_containerizer_tests.cpp > c0dda11c18a770f594b9dcf2e506ec624706dbbd > > Diff: https://reviews.apache.org/r/51405/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
