> On Aug. 25, 2016, 10:57 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 204 > > <https://reviews.apache.org/r/51343/diff/1/?file=1482198#file1482198line204> > > > > Why this change? Where is the error checking?
I removed the error check because it seems redundant to me. We construct the `backends` hashmap from `Backend::Create()`. The backends information from the filesystem (returned from `listContainerRootfses`) should only contain the backends that are included in `Backend::create()`. So this error should be never triggered. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51343/#review146820 ----------------------------------------------------------- On Aug. 23, 2016, 10:19 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51343/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 10:19 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > This patch removed the unnecessary loop to construct an identical > hashmap for info->rootfses. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 8e35ff49ec99a242e764095dcfbb541c5e41ec71 > > Diff: https://reviews.apache.org/r/51343/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
