----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/#review146780 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 41) <https://reviews.apache.org/r/51096/#comment213444> I think we do not have to initialize it with `""` explicitly, just `string config` should be OK. - Qian Zhang On Aug. 22, 2016, 11:26 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51096/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 11:26 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > The `mesos-port-mapper` is a CNI plugin that can be used to install > port-forwarding rules for a container. The `mesos-port-mapper` is a > wrapper CNI plugin that should always be used in conjunction with > other CNI plugins. > > > Diffs > ----- > > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/51096/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
