> On Aug. 24, 2016, 12:38 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 3257 > > <https://reviews.apache.org/r/51320/diff/1/?file=1481651#file1481651line3257> > > > > do you want to add a "messages_launch_task_groups" metric?
My understanding is that `messages_launch_tasks` remains for backwards compatibility and going forward we'll want call-based metrics. For example: ``` calls: 100 calls/decline: 90, calls/accept: 10, calls/accept/operations/create: 1, calls/accept/operations/destroy: 0, calls/accept/operations/launch: 4, calls/accept/operations/launch_group: 2, calls/accept/operations/reserve: 1, calls/accept/operations/unreserve: 0, ``` I filed [MESOS-6082](https://issues.apache.org/jira/browse/MESOS-6082) and [MESOS-6083](https://issues.apache.org/jira/browse/MESOS-6083) to reflect this. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51320/#review146585 ----------------------------------------------------------- On Aug. 23, 2016, 5:11 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51320/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 5:11 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6045 > https://issues.apache.org/jira/browse/MESOS-6045 > > > Repository: mesos > > > Description > ------- > > This operation is all-or-nothing, in that all tasks must be > launched together. If the operation fails, all tasks will > fail with TASK_ERROR and the appropriate GROUP reason. > If a task was killed before delivery to the executor, all > tasks are killed. > > > Diffs > ----- > > include/mesos/mesos.proto 53b6547281b23ce9f47c9f1a418b60667fb4f602 > include/mesos/v1/mesos.proto f6b59e156c92a26dd63b11bf403bdba677b9644b > src/master/master.cpp d94a8510c4cee9c010706f79caf27ef4a10b41a8 > src/messages/messages.proto 7b5e24fb1e9baf09ce024daeca90745f380d4c2f > > Diff: https://reviews.apache.org/r/51320/diff/ > > > Testing > ------- > > Added a test in the subsequent patch. > > More tests will be added for all-or-nothing validation / authorization paths. > > > Thanks, > > Benjamin Mahler > >
