----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51319/#review146565 -----------------------------------------------------------
Ship it! src/tests/master_validation_tests.cpp (line 696) <https://reviews.apache.org/r/51319/#comment213069> A TASK_RUNNING would've been nice instead of TASK_FAILED which might trip up readers. I think if you use a test containerizer with mock executor that should work? Anyway up to you. - Vinod Kone On Aug. 23, 2016, 5:11 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51319/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 5:11 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Removed a hard CHECK for ExecutorInfo.framework_id. > > > Diffs > ----- > > src/master/validation.cpp 30319e75d77546754cdc1f39a8a7c5f9d267e80c > src/tests/master_validation_tests.cpp > e1a5030d0ec8db978df7f785e3a842b1e81f0d5b > > Diff: https://reviews.apache.org/r/51319/diff/ > > > Testing > ------- > > Also added an explicit test to ensure that the filling in > functions correctly. This was captured by most other tests, > but wanted to have one that was responsible for testing only > this behavior. > > > Thanks, > > Benjamin Mahler > >
