----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51295/ -----------------------------------------------------------
Review request for mesos, Artem Harutyunyan and Alex Clemmer. Summary (updated) ----------------- Updated `setsid` behavior in the logrotate container logger. Repository: mesos Description (updated) ------- This patch moves the `setsid` call out of the logger's companion binary. This also allows the logrotate logger to compile on Windows. Diffs (updated) ----- src/slave/container_loggers/lib_logrotate.cpp 1fca4864457388b265779fbca72296336f1aa5a9 src/slave/container_loggers/logrotate.hpp 96697d46ca71e7f62119f2fe669230cf5a04242f src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/51295/diff/ Testing (updated) ------- make check (OSX) See next patch for Windows related testing. Thanks, Joseph Wu
