----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/#review145918 -----------------------------------------------------------
include/mesos/resources.hpp (lines 56 - 62) <https://reviews.apache.org/r/50836/#comment212281> Add a comment. ``` // Forward declarations required for making `convertJSON` a friend of `Resources`. ``` include/mesos/resources.hpp (line 59) <https://reviews.apache.org/r/50836/#comment212273> I think it would still work if you keep the `static` keyword right? The `friend` keyword wouldn't allow you to specify `static` but here you can. Then in the cpp files you don't have to remove the `static` keyword on the definition. - Jiang Yan Xu On Aug. 5, 2016, 12:31 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50836/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2016, 12:31 a.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > We do not want people call add/subtract resoure object directly, > so should make those methods as private. > > > Diffs > ----- > > include/mesos/resources.hpp bdbe8ea03a50cd1361640bde13a2342909723fc5 > include/mesos/v1/resources.hpp c05cb634c7a5add78da00cb84fc75d3472a341bc > src/common/resources.cpp 2470c0280db7d48d9484c42bc2150e53e7ce6e1c > src/v1/resources.cpp 6c4e3b299e701d477947dd7427c31d2ae64c05ae > > Diff: https://reviews.apache.org/r/50836/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh --gtest_filter="ResourcesTest.*" > ./bin/mesos-tests.sh --gtest_filter="SharedResourcesTest.*" > ``` > > > Thanks, > > Guangya Liu > >
