----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review145747 -----------------------------------------------------------
src/slave/containerizer/docker.hpp (line 255) <https://reviews.apache.org/r/50841/#comment212107> What about ``` Allocate GPU resources for a specified container. ``` src/slave/containerizer/docker.hpp (line 257) <https://reviews.apache.org/r/50841/#comment212109> s/size_t/const size_t src/slave/containerizer/docker.hpp (line 260) <https://reviews.apache.org/r/50841/#comment212108> What about comments as this: ``` Deallocate GPU resources for a specified container. ``` src/slave/containerizer/docker.cpp (line 653) <https://reviews.apache.org/r/50841/#comment212110> s/size_t/const size_t src/slave/containerizer/docker.cpp (lines 694 - 696) <https://reviews.apache.org/r/50841/#comment212158> What about move this right after the check so as to fail fast? ``` if (containers_[containerId]->gpuAllocated.empty()) { return Nothing(); } ``` src/slave/containerizer/docker.cpp (line 706) <https://reviews.apache.org/r/50841/#comment212162> <p>I think this should be put into <code>onReady</code> section as https://github.com/apache/mesos/blob/master/src/log/log.cpp#L116-L119</p> src/slave/containerizer/docker.cpp (line 1355) <https://reviews.apache.org/r/50841/#comment212159> s/size_t/const size_t src/slave/containerizer/docker.cpp (line 1378) <https://reviews.apache.org/r/50841/#comment212163> Keep this align with `.then(` in 1376 - Guangya Liu On 八月 15, 2016, 7:26 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50841/ > ----------------------------------------------------------- > > (Updated 八月 15, 2016, 7:26 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added control logic to allocate/deallocate GPUs to GPU-related task > when the task is started/terminated. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d > src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 > > Diff: https://reviews.apache.org/r/50841/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
