----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51061/#review145781 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto (lines 1237 - 1245) <https://reviews.apache.org/r/51061/#comment212150> Per our conversation, maybe a TODO to consider deprecating Launch in favor of LaunchGroup? include/mesos/mesos.proto (lines 1239 - 1241) <https://reviews.apache.org/r/51061/#comment212151> Maybe also mention here that if the scheduler omits, the scheduler should make sure that the offer contains enough to also include the default executor resources? include/mesos/mesos.proto (lines 1239 - 1240) <https://reviews.apache.org/r/51061/#comment212152> Sounds like you can omit the sentence about not setting ExecutorInfo.command if you add the 'type' field that we talked about in ExecutorInfo? include/mesos/mesos.proto (lines 1374 - 1375) <https://reviews.apache.org/r/51061/#comment212143> Maybe: The executor will receive the group in a single message to allow the group to be launched "atomically". - Benjamin Mahler On Aug. 12, 2016, 11:12 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51061/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 11:12 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin Mahler, > James DeFelice, and Jie Yu. > > > Bugs: MESOS-6036 > https://issues.apache.org/jira/browse/MESOS-6036 > > > Repository: mesos > > > Description > ------- > > A scheduler can use the LAUNCH_GROUP offer operation to send a > `TaskGroup` to an executor. > > > Diffs > ----- > > include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 > include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 > src/common/resources.cpp 6b7af9179121efbdc5c29484eb042778bcea8288 > src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 > src/v1/resources.cpp 03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998 > > Diff: https://reviews.apache.org/r/51061/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
