> On Aug. 12, 2016, 10:55 p.m., Joseph Wu wrote: > > configure.ac, lines 1803-1806 > > <https://reviews.apache.org/r/50912/diff/3/?file=1471509#file1471509line1803> > > > > Can you add a comment saying that we already check for python > 2.6 > > about 500 lines up (`--enable-python`)?
I decided to add another explicit check for python > 2.6 because it's not guaranteed that the user has specified the `--enable-python` flag while in this code block. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/#review145442 ----------------------------------------------------------- On Aug. 13, 2016, 8:15 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50912/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2016, 8:15 p.m.) > > > Review request for mesos, Haris Choudhary and Joseph Wu. > > > Bugs: MESOS-6008 > https://issues.apache.org/jira/browse/MESOS-6008 > > > Repository: mesos > > > Description > ------- > > Added the infrastructure for a new python-based CLI. > > > Diffs > ----- > > configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 > docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 > src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 > src/cli_new/README.md PRE-CREATION > src/cli_new/activate PRE-CREATION > src/cli_new/bin/config.py PRE-CREATION > src/cli_new/bin/main.py PRE-CREATION > src/cli_new/bin/mesos PRE-CREATION > src/cli_new/bootstrap PRE-CREATION > src/cli_new/deactivate PRE-CREATION > src/cli_new/lib/mesos/__init__.py PRE-CREATION > src/cli_new/lib/mesos/docopt.py PRE-CREATION > src/cli_new/lib/mesos/exceptions.py PRE-CREATION > src/cli_new/lib/mesos/plugins/__init__.py PRE-CREATION > src/cli_new/lib/mesos/plugins/base.py PRE-CREATION > src/cli_new/lib/mesos/util.py PRE-CREATION > src/cli_new/mesos.bash_completion PRE-CREATION > src/cli_new/pip-requirements.txt PRE-CREATION > src/cli_new/pylint.config PRE-CREATION > > Diff: https://reviews.apache.org/r/50912/diff/ > > > Testing > ------- > > ../configure --enable-new-cli > make -C src mesos > src/mesos > > > Thanks, > > Kevin Klues > >
