> On Aug. 10, 2016, 11:14 p.m., Joseph Wu wrote: > > src/executor/executor.cpp, lines 210-216 > > <https://reviews.apache.org/r/50969/diff/1/?file=1470452#file1470452line210> > > > > Let's re-use the parsed value from libprocess. > > > > ``` > > #ifdef USE_SSL_SOCKET > > #include <process/openssl.hpp> > > #endif // USE_SSL_SOCKET > > > > ... > > > > #ifdef USE_SSL_SOCKET > > if (process::network::openssl::flags().enabled) { > > scheme = "https"; > > } > > #endif // USE_SSL_SOCKET > > ``` > > > > Similar below.
Thanks Joseph! Nice improvement. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50969/#review145426 ----------------------------------------------------------- On Aug. 12, 2016, 11:02 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50969/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 11:02 p.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-3753 > https://issues.apache.org/jira/browse/MESOS-3753 > > > Repository: mesos > > > Description > ------- > > This patch updates the SSL-related environment variable > names used in the HTTP API scheduler and executor libraries. > We recently added the `LIBPROCESS_` prefix to these, but > still also look for the older `SSL_` format. > > > Diffs > ----- > > src/executor/executor.cpp d1ec817c53d0224a483fec545031016cf90620da > src/scheduler/scheduler.cpp 276ed10bd439c4a7830447bec5053292fb2ca4e7 > > Diff: https://reviews.apache.org/r/50969/diff/ > > > Testing > ------- > > Tested after the following patch in this chain. > > > Thanks, > > Greg Mann > >
