> On Aug. 9, 2016, 10:06 a.m., Jie Yu wrote:
> > Second thought. we should just to the following in `__provision`:
> > ```
> > #ifdef WINDOWS
> > return ProvisionInfo{...};
> > #else
> > // the original logic.
> > #endif
> > ```Agree. Obviously more clear in this way. Will fix it. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review145223 ----------------------------------------------------------- On Aug. 4, 2016, 10:05 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50810/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 10:05 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Fixed provisioner appc support on windows build. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 40ee1da5ea453127c1e5e4cdf4b9a49bc998698a > > Diff: https://reviews.apache.org/r/50810/diff/ > > > Testing > ------- > > N/A. > > > Thanks, > > Gilbert Song > >
