-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45573/#review143466
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp (line 132)
<https://reviews.apache.org/r/45573/#comment209270>

    Use `Owned<PerfEventHandleManager>` instead



src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp (line 94)
<https://reviews.apache.org/r/45573/#comment209276>

    Use `defer` instead of `lock`


- haosdent huang


On July 21, 2016, 7:11 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45573/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5047
>     https://issues.apache.org/jira/browse/MESOS-5047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add `PerfEventHandleManager`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 1de38491a33e5782b20e5ee491412779d09ee391 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
> 31f35385691681ef5da14be747edfb5f57c5d05a 
> 
> Diff: https://reviews.apache.org/r/45573/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to