----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49269/#review139678 -----------------------------------------------------------
src/slave/http.cpp (lines 1144 - 1145) <https://reviews.apache.org/r/49269/#comment204975> Wrap `result.get()`. src/slave/http.cpp (lines 1150 - 1152) <https://reviews.apache.org/r/49269/#comment204974> I see that you're just moving code around, but since you're touching it, have you considered propagating the original failure instead of repairing? For refenrece, you can look at https://github.com/apache/mesos/commit/da1bab09a6a9585f438b23dd151d13c86fdc1334 and https://github.com/apache/mesos/commit/bb9547694f2cfec5462497c73969a59af4652957 - Alexander Rukletsov On June 27, 2016, 4:06 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49269/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 4:06 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5518 > https://issues.apache.org/jira/browse/MESOS-5518 > > > Repository: mesos > > > Description > ------- > > The helper function returns JSON::Array, which can be > reused by v1 Operator API GET_CONTAINERS. > > > Diffs > ----- > > src/slave/http.cpp c038bf0c9680ec86f77f1a27efeb7354a9e67627 > src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 > > Diff: https://reviews.apache.org/r/49269/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
