----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49171/#review139386 -----------------------------------------------------------
Fix it, then Ship it! docs/networking.md (lines 5 - 8) <https://reviews.apache.org/r/49171/#comment204587> I would suggest that we use the following layout. Mesos and Docker containrs are a little confusing especially Mesos can launch docker containers without daemon. ``` - [Attaching containers to IP networkss] - [Mesos containerizer] - [Docker containerizer] ``` docs/networking.md (line 8) <https://reviews.apache.org/r/49171/#comment204597> This should be at the top level? docs/networking.md (lines 30 - 32) <https://reviews.apache.org/r/49171/#comment204588> I'll be nice to have inline link (hyperlink) docs/networking.md (line 36) <https://reviews.apache.org/r/49171/#comment204589> s/Mesos and Docker// Let's avoid using Mesos container and Docker container. docs/networking.md (line 54) <https://reviews.apache.org/r/49171/#comment204591> kill extra lines here docs/networking.md (line 59) <https://reviews.apache.org/r/49171/#comment204592> DItto. docs/networking.md (line 61) <https://reviews.apache.org/r/49171/#comment204593> Ditto. docs/networking.md (line 63) <https://reviews.apache.org/r/49171/#comment204594> Ditto. docs/networking.md (line 69) <https://reviews.apache.org/r/49171/#comment204595> s/Mesos and Docker// docs/networking.md (lines 109 - 112) <https://reviews.apache.org/r/49171/#comment204596> Kill those - Jie Yu On June 24, 2016, 3:27 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49171/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 3:27 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5699 > https://issues.apache.org/jira/browse/MESOS-5699 > > > Repository: mesos > > > Description > ------- > > The `Networking` section describes the infrastructure available in > Mesos, specifically the `MesosContainerizer` and `DockerContainerizer` > to attach Mesos and Docker containers to IP Networks. > > > Diffs > ----- > > docs/networking.md PRE-CREATION > > Diff: https://reviews.apache.org/r/49171/diff/ > > > Testing > ------- > > https://github.com/asridharan/mesos/blob/docs/docs/networking.md > > > Thanks, > > Avinash sridharan > >
