----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138628 -----------------------------------------------------------
src/master/quota_handler.cpp (lines 362 - 363) <https://reviews.apache.org/r/48268/#comment203821> How about ``` VLOG(1) << "Using force flag to override quota" << "capacity heuristic check"; ``` src/master/quota_handler.cpp (line 379) <https://reviews.apache.org/r/48268/#comment203822> I think `NOTE:` should start at a new line. ``` // multi-phase event). // NOTE: We do not need to remove quota for the role if the registry ``` src/master/quota_handler.cpp (line 396) <https://reviews.apache.org/r/48268/#comment203824> Ditto here. src/tests/api_tests.cpp (lines 764 - 770) <https://reviews.apache.org/r/48268/#comment203827> Do we need query the quota to verify if it is set correctly. src/tests/api_tests.cpp (line 772) <https://reviews.apache.org/r/48268/#comment203826> Why print body here? - haosdent huang On June 20, 2016, 7:46 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48268/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 7:46 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5509 > https://issues.apache.org/jira/browse/MESOS-5509 > > > Repository: mesos > > > Description > ------- > > Implemented SET_QUOTA Call in v1 master API. > > > Diffs > ----- > > include/mesos/v1/master/master.proto > abcf628eea7922cdb323ec135ec48e9b11209608 > src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 > src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe > src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d > src/master/quota_handler.cpp 567f1c2cc59b859227a8b48c6086ce3f8049f14d > src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320 > > Diff: https://reviews.apache.org/r/48268/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo GTEST_FILTER="*MasterAPITest.SetQuota*" make -j4 check > > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from ContentType/MasterAPITest > [ RUN ] ContentType/MasterAPITest.SetQuota/0 > [ OK ] ContentType/MasterAPITest.SetQuota/0 (129 ms) > [ RUN ] ContentType/MasterAPITest.SetQuota/1 > [ OK ] ContentType/MasterAPITest.SetQuota/1 (98 ms) > [----------] 2 tests from ContentType/MasterAPITest (227 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (236 ms total) > [ PASSED ] 2 tests. > > > Thanks, > > Abhishek Dasgupta > >
