> On June 19, 2016, 9:27 p.m., Kevin Klues wrote: > > src/tests/api_tests.cpp, lines 419-421 > > <https://reviews.apache.org/r/48094/diff/6/?file=1423446#file1423446line419> > > > > It's not here in the review, but the final committed version of this > > patch contains these lines as: > > ``` > > slave::Flags slaveFlags = CreateSlaveFlags(); > > slaveFlags.resources = > > "cpus(role1):0.5;mem(role1):512;ports(role1):[31000-31001];" > > "disk(role1):1024;gpus(role1):1"; > > ``` > > > > This breaks the unit tests on machines that *actually* contain GPUs. > > Was there a reason for adding the `gpus(role1):1` resource?
Nopes, we can easily get away with not setting the GPU resource but just defaulting it to `0`. Posted a patch to fix it: https://reviews.apache.org/r/48933/ - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138482 ----------------------------------------------------------- On June 18, 2016, 4:21 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48094/ > ----------------------------------------------------------- > > (Updated June 18, 2016, 4:21 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5494 > https://issues.apache.org/jira/browse/MESOS-5494 > > > Repository: mesos > > > Description > ------- > > Implemented GET_ROLES Call in v1 master API. > > > Diffs > ----- > > include/mesos/master/master.proto fa92240 > include/mesos/mesos.proto e4c5bd3 > include/mesos/v1/master/master.proto 59e978f > include/mesos/v1/mesos.proto 9be22f0 > src/master/http.cpp a6beb17 > src/master/master.hpp 618d928 > src/tests/api_tests.cpp afa5ffa > > Diff: https://reviews.apache.org/r/48094/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > > sudo GTEST_FILTER="*MasterAPITest.*" make -j2 check > > > Thanks, > > Abhishek Dasgupta > >
