----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138169 -----------------------------------------------------------
src/master/http.cpp (line 2485) <https://reviews.apache.org/r/48094/#comment203380> Hi, @a10gupta Could not got the idea that why you rename to `_roles` here. Seems you have never reuse this function? - haosdent huang On June 16, 2016, 10:48 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48094/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 10:48 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5494 > https://issues.apache.org/jira/browse/MESOS-5494 > > > Repository: mesos > > > Description > ------- > > Implemented GET_ROLES Call in v1 master API. > > > Diffs > ----- > > include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 > include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d > src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 > src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b > src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 > src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 > src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 > > Diff: https://reviews.apache.org/r/48094/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > > sudo GTEST_FILTER="*MasterAPITest.*" make -j2 check > > > Thanks, > > Abhishek Dasgupta > >
