> On April 11, 2016, 9:43 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 353-376 > > <https://reviews.apache.org/r/46025/diff/1/?file=1339340#file1339340line353> > > > > One question I have looking at this is whether we would benefit from > > more explicit structure here: > > > > ``` > > struct > > { > > map<int, Socket*> sockets; > > map<int, Address> addresses; > > set<int> dispose; > > map<Address, int> temps; > > map<Address, int> persists; > > map<int, queue<Encoder*>> outgoing; > > } outbound; > > > > struct > > { > > map<int, Socket*> sockets; > > } inbound; > > ``` > > > > This assumes we don't need to track both inbound and outbound within > > the same map. From a quick glance at the code I can't see any reason to > > store them in the same map but perhaps I'm missing something. > > > > There seems to be potential for significant consolidation of the > > outbond structures as well.
You could certainly reorganize the libprocess data structures significantly, but I'd prefer to defer that to later. Happy to open a JIRA if you'd like. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46025/#review128259 ----------------------------------------------------------- On April 11, 2016, 2:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46025/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 2:35 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Clarified comments on socket data structures in SocketManager. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46025/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
