> On May 13, 2016, 9:59 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 27 > > <https://reviews.apache.org/r/47362/diff/1/?file=1383164#file1383164line27> > > > > #include <stout/try.hpp>
I didn't want to mix cleanups in this patch given that Try is already required, there are additional headers that are missing. I'll follow up with a separate patch. > On May 13, 2016, 9:59 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 754 > > <https://reviews.apache.org/r/47362/diff/1/?file=1383164#file1383164line754> > > > > s/send(/send (/ I originally wanted to maintain consistency of comments these tests (this comment is used elsewhere), but I'll just rephrase it. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/#review133213 ----------------------------------------------------------- On May 13, 2016, 9:46 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47362/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 9:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil > Conway. > > > Bugs: MESOS-5340 > https://issues.apache.org/jira/browse/MESOS-5340 > > > Repository: mesos > > > Description > ------- > > This test works by creating a connection on which no data is sent (the SSL > handshake does not complete, nor is the socket downgraded). After which, we > expect that an HTTP request should succeed. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 4d237815a03828b915e821c3af78132e2915c610 > > Diff: https://reviews.apache.org/r/47362/diff/ > > > Testing > ------- > > This test fails before the fix in MESOS-5340. > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from SSLTest > [ RUN ] SSLTest.SilentSocket > ../../../3rdparty/libprocess/src/tests/ssl_tests.cpp:752: Failure > Failed to wait 15secs for socket > [ FAILED ] SSLTest.SilentSocket (15221 ms) > [----------] 1 test from SSLTest (15221 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (15222 ms total) > [ PASSED ] 0 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] SSLTest.SilentSocket > ``` > > > Thanks, > > Benjamin Mahler > >
