----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review136828 -----------------------------------------------------------
src/scheduler/scheduler.cpp (line 73) <https://reviews.apache.org/r/48387/#comment201915> Mesos style require header file sort by alphabectial. Should add it like ``` #include "messages/messages.hpp" #include "scheduler/flags.hpp" using namespace mesos; ``` src/scheduler/scheduler.cpp (line 196) <https://reviews.apache.org/r/48387/#comment201912> According to mesos style, this variable name should be `connectionBackoffMax` I saw `slave.cpp`, `executor.cpp`, `sched.cpp` use `maxBackoff` as variable name. src/scheduler/scheduler.cpp (line 480) <https://reviews.apache.org/r/48387/#comment201913> `Will retry connecting with the master again in ` src/scheduler/scheduler.cpp (line 739) <https://reviews.apache.org/r/48387/#comment201914> Need change the name here. - haosdent huang On June 8, 2016, 8:53 a.m., Jose Guilherme Vanz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48387/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 8:53 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The scheduler library has been updated to wait a little deley before > initiate a connection with the master. The maximum amount of time waited > by the scheduler is defined by a flag: CONNECTION_BACKOFF_MAX. After > the master has been detected the scheduler picks a random delay that > can be between 0 and the CONNECTION_BACKOFF_MAX value. MESOS-5359 > > > Diffs > ----- > > src/scheduler/constants.hpp PRE-CREATION > src/scheduler/flags.hpp PRE-CREATION > src/scheduler/scheduler.cpp c79837c93e7329dbfa22e4288b44237f33408ba9 > > Diff: https://reviews.apache.org/r/48387/diff/ > > > Testing > ------- > > > Thanks, > > Jose Guilherme Vanz > >
