----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46407/#review136538 -----------------------------------------------------------
Fix it, then Ship it! src/examples/balloon_executor.cpp (line 143) <https://reviews.apache.org/r/46407/#comment201598> s/scheduler/executor/ ? src/examples/balloon_executor.cpp (lines 152 - 156) <https://reviews.apache.org/r/46407/#comment201600> any particular reason TASK_RUNNING is sent by this thread instead of `thread`? because, as it currently stands, `thread` might theoretically send its update before this thread sends TASK_RUNNING. - Vinod Kone On June 6, 2016, 11:48 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46407/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 11:48 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5174 > https://issues.apache.org/jira/browse/MESOS-5174 > > > Repository: mesos > > > Description > ------- > > Fixes the logic in the example `balloon-executor` to work in cases not > exercised by the `ROOT_CGROUPS_BalloonFramework` test. > > * The "task" logic was moved into a separate thread. This fixes the > case where the balloon executor does not exceed the memory limit. > (i.e. by Unblocking the driver's thread while sending status updates.) > * Changed log messages to use glog. > * Added logic to prevent multiple task launches with the same executor. > > > Diffs > ----- > > src/examples/balloon_executor.cpp 2a79c353e96930d25495732d15b83c82247974bb > > Diff: https://reviews.apache.org/r/46407/diff/ > > > Testing > ------- > > See next review in this chain. > > > Thanks, > > Joseph Wu > >
