----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/#review136392 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (lines 139 - 140) <https://reviews.apache.org/r/47396/#comment201447> // See http://aufs.sourceforge.net/aufs2/man.html for the // mount syntax for aufs. nit: What about update as above to make it less jagged? src/tests/containerizer/provisioner_backend_tests.cpp (lines 253 - 254) <https://reviews.apache.org/r/47396/#comment201445> one line is enough src/tests/environment.cpp (lines 492 - 495) <https://reviews.apache.org/r/47396/#comment201444> I think that here also needs to be updated to use your new function `fs::aufs::supported()` to check `aufs`? src/tests/environment.cpp (lines 544 - 555) <https://reviews.apache.org/r/47396/#comment201446> Move this above `OverlayFSFilter` so as to keep alpha order? - Guangya Liu On 六月 6, 2016, 11:57 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47396/ > ----------------------------------------------------------- > > (Updated 六月 6, 2016, 11:57 p.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu. > > > Bugs: MESOS-4672 > https://issues.apache.org/jira/browse/MESOS-4672 > > > Repository: mesos > > > Description > ------- > > Added aufs provisioning backend. > > > Diffs > ----- > > src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 > src/slave/containerizer/mesos/provisioner/backend.cpp > b2a20b7c08fa790da09ba05b725248e42b8d3bc4 > src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION > src/tests/containerizer/provisioner_backend_tests.cpp > bc04760c9504ea55cd4bb72c7e9012e43a5911aa > src/tests/environment.cpp 849e9ce05864f6ec1a736dfc1a7a31d2364c84bf > > Diff: https://reviews.apache.org/r/47396/diff/ > > > Testing > ------- > > - Make check on ubuntu 14.04 64bit > - Test manually: start slave with aufs backend, and write a simple script > that launches tasks with alpine/ubuntu images > > > Thanks, > > Shuai Lin > >
