----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review136037 -----------------------------------------------------------
Patch looks great! Reviews applied: [46498] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 3, 2016, 3:45 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46498/ > ----------------------------------------------------------- > > (Updated June 3, 2016, 3:45 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > Add runtime for Appc Spec ex: command, workingdir and environment. > > > Diffs > ----- > > include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 > include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 > src/Makefile.am c0be66ab28c452e217fe7c7ead8b1b3c283908cc > src/slave/containerizer/mesos/containerizer.cpp > c7b9744463cf8e1921dcb5e2b7dec7d4e2c0e45f > src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/appc/store.cpp > aaa0efe63e587b9e604082b52a3cb8c11545fbb9 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 48a05059969e068a0ee0d38b61be9e7104e3188d > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 7540be6d8a412eb3d380d315c59223236d3eff67 > src/slave/containerizer/mesos/provisioner/store.hpp > 1d477ef13ddd24fd8badae0decaa4a2271ecc746 > src/tests/containerizer/provisioner_appc_tests.cpp > 84fe52b6937c3b7d7628b17a2f045eec2f386b4d > > Diff: https://reviews.apache.org/r/46498/diff/ > > > Testing > ------- > > > Thanks, > > Srinivas Brahmaroutu > >
