----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/#review135592 -----------------------------------------------------------
src/health-check/main.cpp (line 309) <https://reviews.apache.org/r/47577/#comment200628> No need to do this src/slave/slave.cpp (lines 1032 - 1040) <https://reviews.apache.org/r/47577/#comment200629> I still think you have changes accidentally merged together. src/zookeeper/group.cpp (lines 658 - 659) <https://reviews.apache.org/r/47577/#comment200630> wrapping: ``` string path = path::join( znode, zkBasename(membership), os::POSIX_PATH_SEPARATOR); ``` src/zookeeper/group.cpp (lines 699 - 700) <https://reviews.apache.org/r/47577/#comment200631> same as above - Joris Van Remoortere On May 30, 2016, 10:19 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47577/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 10:19 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Agent: Added minor changes to various .cpp files to support Windows. > > > Diffs > ----- > > src/docker/docker.cpp 19cf424dfd5748ae66a7023840aa2b0652e8f2c0 > src/docker/executor.cpp f4796e4aa9951c30ada7feb44fb5d037895becce > src/files/files.cpp 074d31c116c1b9ff96262c3e0c776f38aea53d16 > src/health-check/main.cpp 3cf858303ee84f43aedfe5ac71949b786276e463 > src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 > src/slave/slave.cpp c235c14814c320b4a8af8bf839ecced969de6e35 > src/uri/fetcher.hpp 8af2c9122e0b15fd54f7d3a84779540e7186f566 > src/uri/fetcher.cpp aa9df5d0256a26b8684934c2bd37b82a069088f7 > src/uri/fetchers/copy.cpp 2180adfba1f33852d11069eed9d9bca72e2e3b6f > src/uri/fetchers/curl.cpp c4420623d718d87776f2eb8e13faf02ef5edb335 > src/zookeeper/group.cpp 01680899778e554af70b176db82498ca92b51b60 > > Diff: https://reviews.apache.org/r/47577/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
