----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47521/#review135194 -----------------------------------------------------------
src/tests/persistent_volume_endpoints_tests.cpp (line 660) <https://reviews.apache.org/r/47521/#comment200231> I don't think the reservation principal should be necessary here. Should not have any effect either way, right? But the documentation for this recommends not setting a reservation principal unless there is a reservation. Also I think we can avoid confusing by using None() here instead, so it is clear which parameter triggers the expected response. src/tests/persistent_volume_endpoints_tests.cpp (line 718) <https://reviews.apache.org/r/47521/#comment200232> Same here. src/tests/persistent_volume_endpoints_tests.cpp (line 1010) <https://reviews.apache.org/r/47521/#comment200233> In the above case, this part is within the scope block, here it is not. Please move the opening curly brace up. - Bernd Mathiske On May 26, 2016, 10:37 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47521/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 10:37 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway. > > > Bugs: MESOS-5005 > https://issues.apache.org/jira/browse/MESOS-5005 > > > Repository: mesos > > > Description > ------- > > A creator principal is added to the persistent volumes > used in the PersistentVolumeEndpointsTests. > > > Diffs > ----- > > src/tests/persistent_volume_endpoints_tests.cpp > a57461d881b2bf0175f83b50b0a46167acd5bd3e > > Diff: https://reviews.apache.org/r/47521/diff/ > > > Testing > ------- > > `make check` was used to test on OSX. > > > Thanks, > > Greg Mann > >
