----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review134659 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/fetcher.cpp (lines 210 - 211) <https://reviews.apache.org/r/47472/#comment199505> Why is this logic compiled out on windows? Does it not apply? If so, can we add a comment? If it does, but we can't implement it, can we add a `TODO` referencing a JIRA? If the issue is the slash separator, should we be using the new constant you introduced? `os::PATH_SEPARATOR`? src/slave/containerizer/fetcher.cpp (lines 311 - 312) <https://reviews.apache.org/r/47472/#comment199506> A `TODO` referencing the JIRA to add support would be good. src/slave/containerizer/fetcher.cpp (line 365) <https://reviews.apache.org/r/47472/#comment199507> Missing period. Can we wrap `os::chown` with backticks and remove the parentheses? src/slave/containerizer/fetcher.cpp (lines 750 - 752) <https://reviews.apache.org/r/47472/#comment199508> In Mesos we use `camelCase`. Sorry for the current inconsistency in the project. Either `_stderr` or `stderrSandbox` would be fine here. src/slave/containerizer/fetcher.cpp (line 761) <https://reviews.apache.org/r/47472/#comment199509> can you use `os::chown` instead of `chown` here to be consistent with your comment higher up in the file? - Joris Van Remoortere On May 17, 2016, 4:02 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47472/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 4:02 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3618 > https://issues.apache.org/jira/browse/MESOS-3618 > > > Repository: mesos > > > Description > ------- > > Windows: Added support for `fetcher.cpp`. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 176d8863d1becd8864218a0012ab45c614f0ad77 > > Diff: https://reviews.apache.org/r/47472/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
