----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review134461 -----------------------------------------------------------
docs/docker-volume-isolator.md (line 7) <https://reviews.apache.org/r/47511/#comment199261> Could we add a section #Motivation? docs/docker-volume-isolator.md (line 8) <https://reviews.apache.org/r/47511/#comment199263> The docker volume isolator is introduced... docs/docker-volume-isolator.md (lines 17 - 20) <https://reviews.apache.org/r/47511/#comment199262> newline for each. docs/docker-volume-isolator.md (line 24) <https://reviews.apache.org/r/47511/#comment199264> Remove "The rest of this document" docs/docker-volume-isolator.md (line 30) <https://reviews.apache.org/r/47511/#comment199266> s/docker volume driver isolator/ docker volume isolator/g docs/docker-volume-isolator.md (line 33) <https://reviews.apache.org/r/47511/#comment199268> When a new task with docker volumes specified is launched docs/docker-volume-isolator.md (lines 33 - 40) <https://reviews.apache.org/r/47511/#comment199271> Merge together and rephase. docs/docker-volume-isolator.md (line 42) <https://reviews.apache.org/r/47511/#comment199272> Move this below when introducing `container_path`: The docker volume isolator supports tasks with/without rootfs: with rootfs v.s. without rootfs absolute path v.s. relative path docs/docker-volume-isolator.md (lines 45 - 52) <https://reviews.apache.org/r/47511/#comment199273> kill this. docs/docker-volume-isolator.md (lines 54 - 75) <https://reviews.apache.org/r/47511/#comment199275> kill this. Generally, we may not need to explain the implementation in detail. Let's just explain the diagram and mention the recoverablity in one sentence. docs/docker-volume-isolator.md (lines 79 - 80) <https://reviews.apache.org/r/47511/#comment199282> could we rephase? docs/docker-volume-isolator.md (line 84) <https://reviews.apache.org/r/47511/#comment199281> let's numify each step: 1. pre-condition 2. configuration ... docs/docker-volume-isolator.md (lines 91 - 92) <https://reviews.apache.org/r/47511/#comment199285> strongly recommend to create volumes explicitly, otherwise, volumes will be created by dvdcli. docs/docker-volume-isolator.md (lines 106 - 107) <https://reviews.apache.org/r/47511/#comment199286> dependency on linux filesystem isolator. docs/docker-volume-isolator.md (lines 120 - 187) <https://reviews.apache.org/r/47511/#comment199290> let's just pick out related message fields and filter out all comments. docs/docker-volume-isolator.md (lines 198 - 209) <https://reviews.apache.org/r/47511/#comment199292> could we draw a table? docs/docker-volume-isolator.md (line 200) <https://reviews.apache.org/r/47511/#comment199291> if it is a command task V.S. a mesos container with a specified image... docs/docker-volume-isolator.md (line 213) <https://reviews.apache.org/r/47511/#comment199293> please fix the grammar. docs/docker-volume-isolator.md (lines 216 - 288) <https://reviews.apache.org/r/47511/#comment199294> we dont need this if we explain ContainerInfo.Volumes above. docs/docker-volume-isolator.md (line 290) <https://reviews.apache.org/r/47511/#comment199295> could rephase and fix the grammar. docs/docker-volume-isolator.md (line 302) <https://reviews.apache.org/r/47511/#comment199303> do we need this section for now? since users may not be able to test it out depending on the code base. docs/docker-volume-isolator.md (lines 329 - 339) <https://reviews.apache.org/r/47511/#comment199299> kill this. docs/docker-volume-isolator.md (line 341) <https://reviews.apache.org/r/47511/#comment199301> let's add it later. - Gilbert Song On May 20, 2016, 6:51 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47511/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 6:51 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5216 > https://issues.apache.org/jira/browse/MESOS-5216 > > > Repository: mesos > > > Description > ------- > > Added documentation for `docker/volume` isolator. > > > Diffs > ----- > > docs/docker-volume-isolator.md PRE-CREATION > docs/images/docker-volume-isolator.png PRE-CREATION > > Diff: https://reviews.apache.org/r/47511/diff/ > > > Testing > ------- > > You can review the document here: > https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md > > > Thanks, > > Guangya Liu > >
