> On May 15, 2016, 12:57 a.m., Vinod Kone wrote: > > src/examples/test_framework.cpp, line 197 > > <https://reviews.apache.org/r/47208/diff/1/?file=1379226#file1379226line197> > > > > This was added by jpeach for making tests run from the installation > > directory, IIRC. Does this not break that?
Good catch. I added him as a reviewer now. My bad, I needed to fix the other 2 tests that were not consistent with this test. [~jpeach] I hope we add adequate documentation for posterity after introducing new build/install flags so that we are not caught off guard again. Ideally, MESOS-4012 should have been resolved as part of committing MESOS-3608. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47208/#review133294 ----------------------------------------------------------- On May 15, 2016, 6:20 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47208/ > ----------------------------------------------------------- > > (Updated May 15, 2016, 6:20 p.m.) > > > Review request for mesos, James Peach and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This change modifies a couple of existing tests to make them > pass when the mesos tests are configured to be installed. This > also brings the `TestHTTPFramework` test to be at parity with > the `TestFramework` code around finding the executor path logic. > > > Diffs > ----- > > src/examples/test_http_framework.cpp > 683384d986082a24b052505ef6be22b4dc20db00 > src/tests/dynamic_reservation_framework_test.sh > 00a10f18b98df941089d93f0163b644ce537fb04 > > Diff: https://reviews.apache.org/r/47208/diff/ > > > Testing > ------- > > make check > $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none passes now > > > Thanks, > > Anand Mazumdar > >
