----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46392/#review133136 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/windows/fcntl.hpp (line 26) <https://reviews.apache.org/r/46392/#comment197432> can we say `not supported`? here and below. 3rdparty/stout/include/stout/os/windows/fcntl.hpp (line 44) <https://reviews.apache.org/r/46392/#comment197428> space between `){` 3rdparty/stout/include/stout/os/windows/fcntl.hpp (line 45) <https://reviews.apache.org/r/46392/#comment197431> How about `non_block_mode`? 3rdparty/stout/include/stout/os/windows/fcntl.hpp (lines 57 - 64) <https://reviews.apache.org/r/46392/#comment197430> Don't need the else, can just follow through as the previous error checking code returns. 3rdparty/stout/include/stout/os/windows/fcntl.hpp (line 62) <https://reviews.apache.org/r/46392/#comment197429> don't need the semi-colon? - Joris Van Remoortere On May 12, 2016, 6:59 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46392/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 6:59 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-5371 > https://issues.apache.org/jira/browse/MESOS-5371 > > > Repository: mesos > > > Description > ------- > > This commit introduces temporary versions of 2 important functions: > `os::nonblock` and `os::cloexec`. We put them here in a placeholder > commit so that reviewers can make progress on subprocess. In the > immediate term, the plan is to figure out on a callsite-by-callsite > basis how to work around the functionality of `os::cloexec`. When we > collect more data, we will be in a better position to offer a way > forward here. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os.hpp > 25e93200cf8b95f57931771073f3b6e34fff061b > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > 14734317d7fb40053ee808745ac3ba8c706a7669 > > Diff: https://reviews.apache.org/r/46392/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
