----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review133004 -----------------------------------------------------------
Srinivas, thanks for taking this on. It looks like you combined your previous patches (https://reviews.apache.org/r/46107) here. I would advice you to split this patch into 2: - Protobuf changes - Other changes -jojy - Jojy Varghese On May 12, 2016, 9:23 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46498/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 9:23 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > Add runtime for Appc Spec ex: command, workingdir and environment. > > > Diffs > ----- > > include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 > include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 > src/Makefile.am 922b5984b67ace97c142b52aaa8221323147a7ff > src/slave/containerizer/mesos/containerizer.cpp > 1e1a36903f4377497bb72b69e4ead63675d453c0 > src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 5c96e9f6603d39889e6bc807874d35d0cb3556be > src/slave/containerizer/mesos/provisioner/provisioner.cpp > dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 > src/slave/containerizer/mesos/provisioner/store.hpp > 1d477ef13ddd24fd8badae0decaa4a2271ecc746 > src/tests/containerizer/provisioner_appc_tests.cpp > 84fe52b6937c3b7d7628b17a2f045eec2f386b4d > > Diff: https://reviews.apache.org/r/46498/diff/ > > > Testing > ------- > > > Thanks, > > Srinivas Brahmaroutu > >
