----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47078/#review132766 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 149) <https://reviews.apache.org/r/47078/#comment197019> make this `const Option<T2>&` instead? 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 237) <https://reviews.apache.org/r/47078/#comment197020> ditto. use option here. - Vinod Kone On May 7, 2016, 1:27 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47078/ > ----------------------------------------------------------- > > (Updated May 7, 2016, 1:27 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-5064 > https://issues.apache.org/jira/browse/MESOS-5064 > > > Repository: mesos > > > Description > ------- > > Added checking for required flags to FlagsBase. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp > 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 > > Diff: https://reviews.apache.org/r/47078/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
