----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/#review132748 -----------------------------------------------------------
Can you expand the description about why we should only be adding member variables for correct copy semantics? 3rdparty/libprocess/src/tests/subprocess_tests.cpp (lines 519 - 526) <https://reviews.apache.org/r/46823/#comment196995> I was expecting the Flags::add() overload to only accept member variables. Why do you need to change the call site instead? - Vinod Kone On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46823/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 9:37 a.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-3335 > https://issues.apache.org/jira/browse/MESOS-3335 > > > Repository: mesos > > > Description > ------- > > While right now we can technically `add` variables to `Flags` classes > which are not members, the in order to have correct copy semantics for > `Flags` only member variables should be used. > > Here we changed all instances to a full pointer-to-member syntax in > the current code. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 727e940f12643974de4ff2734fba431b285b5de3 > > Diff: https://reviews.apache.org/r/46823/diff/ > > > Testing > ------- > > Tested on various platforms in internal CI. > > > Thanks, > > Benjamin Bannier > >
