----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review132652 -----------------------------------------------------------
Fix it, then Ship it! src/master/http.cpp (lines 869 - 878) <https://reviews.apache.org/r/46784/#comment196925> Could you please add a TODO here that this blob should be extracted in a separate function? src/master/master.hpp (lines 1235 - 1239) <https://reviews.apache.org/r/46784/#comment196929> Maybe you can re-wrap it for readability. src/master/master.hpp (lines 1239 - 1240) <https://reviews.apache.org/r/46784/#comment196928> Blank line. src/tests/master_authorization_tests.cpp (lines 1020 - 1026) <https://reviews.apache.org/r/46784/#comment196927> Could you also please add an "integration" test that uses real authorizers? Similar to what you have done for the agent. - Alexander Rukletsov On May 10, 2016, 6:03 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46784/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 6:03 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Bugs: MESOS-5297 > https://issues.apache.org/jira/browse/MESOS-5297 > > > Repository: mesos > > > Description > ------- > > Access to the '/flags' endpoint is authorized using > the 'GET_ENDPOINT_WITH_PATH' action. > > > Diffs > ----- > > docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a > src/master/http.cpp a0d67671c89b9794e721dc3ba012acd3bdc447e3 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/tests/master_authorization_tests.cpp > 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 > > Diff: https://reviews.apache.org/r/46784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
