> On May 5, 2016, 6:08 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 292-294 > > <https://reviews.apache.org/r/46491/diff/4/?file=1373528#file1373528line292> > > > > This is confusing to me, it just means a retry as far as this patch is > > concerned. Can you remove this TODO? > > Alexander Rukletsov wrote: > See above.
The comment is food for thought . There is actually one more state, which we ignore for now, but I would like to make readers aware about it. People look at this code when they implement their own executors. I have rephrased it for clarity. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review131880 ----------------------------------------------------------- On May 7, 2016, 1:02 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46491/ > ----------------------------------------------------------- > > (Updated May 7, 2016, 1:02 p.m.) > > > Review request for mesos, Benjamin Bannier and Ben Mahler. > > > Bugs: MESOS-5240 > https://issues.apache.org/jira/browse/MESOS-5240 > > > Repository: mesos > > > Description > ------- > > Capture the state when a task has terminated (i.e., reaped) in a flag, > and use it to prevent calls to `killTask()` and `escalated()` when > they are executed after the task has terminated. > > > Diffs > ----- > > src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 > src/launcher/executor.cpp 4d5e2a9b876cd65be1386bf170dba2f71af86750 > src/launcher/http_command_executor.cpp > d2f15b0447d91f3a4cd92f07114cb366647cc7d3 > > Diff: https://reviews.apache.org/r/46491/diff/ > > > Testing > ------- > > `make check` on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
