> On May 7, 2016, 12:24 p.m., Adam B wrote:
> > src/master/http.cpp, line 869
> > <https://reviews.apache.org/r/46784/diff/3/?file=1369724#file1369724line869>
> >
> > Did you need to pass all ("=") the in-scope variables through to the
> > lambda, or just `request`?
Yes, I only need to capture `request` here, but the way I understand the C++
style guide, "default capture by value" ("=") is preferred over "explicit
capture by value".
> On May 7, 2016, 12:24 p.m., Adam B wrote:
> > src/master/http.cpp, line 2846
> > <https://reviews.apache.org/r/46784/diff/3/?file=1369724#file1369724line2846>
> >
> > There's a lot of code duplication between here and
> > `Slave::Http::authorizeEndpoint()`. Can you share/reuse code between the
> > two?
Indeed, that's quite some code duplication. But there are also some slight
differences in both functions. Had a discussion with @arojas about how to
handle that case. On one hand it's good to remove code duplication, on the
other hand the extracted function would look a bit more complicated to support
the different requirements of master and agent. We decided that in this
particular case it's okay to stick with the two similar functions.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46784/#review132125
-----------------------------------------------------------
On May 3, 2016, 2:42 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46784/
> -----------------------------------------------------------
>
> (Updated May 3, 2016, 2:42 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Bugs: MESOS-5297
> https://issues.apache.org/jira/browse/MESOS-5297
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Access to the '/flags' endpoint is authorized using
> the 'GET_ENDPOINT_WITH_PATH' action.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19
> src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052
> src/tests/master_authorization_tests.cpp
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8
>
> Diff: https://reviews.apache.org/r/46784/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
