----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46606/#review132181 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/tests/os/socket_tests.cpp (lines 27 - 38) <https://reviews.apache.org/r/46606/#comment196348> we can just asser the statements themselves. - Joris Van Remoortere On April 23, 2016, 10:26 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46606/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 10:26 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Stout:[1/2] Added `socket_tests.cpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 10be36652034ea5860f122ffb45ee50cc72ffdb3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > 6290234aa0ac682270cfe3a9512676e181128b60 > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > c9df907dd09de1c09dd8dfb74e052eb2fc8e9935 > 3rdparty/libprocess/3rdparty/stout/tests/os/socket_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46606/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
