> On 五月 3, 2016, 5:28 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, line 204 > > <https://reviews.apache.org/r/46140/diff/4/?file=1369618#file1369618line204> > > > > > > `s/ROOT_LaunchCommandExecutorNoRootfsWithSingleVolume/ROOT_CommandTaskNoRootfs/`
I was renaming it to `ROOT_CommandTaskNoRootfsSingleVolume` cause I will have other test case with multiple volumes. > On 五月 3, 2016, 5:28 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, lines 214-215 > > <https://reviews.apache.org/r/46140/diff/4/?file=1369618#file1369618line214> > > > > Is it used? Yes, it will be called when generating the mount point. > On 五月 3, 2016, 5:28 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, line 223 > > <https://reviews.apache.org/r/46140/diff/4/?file=1369618#file1369618line223> > > > > is it used? Yes, it will be called when clean up the container. > On 五月 3, 2016, 5:28 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, lines 214-227 > > <https://reviews.apache.org/r/46140/diff/4/?file=1369618#file1369618line214> > > > > I think you should move this down right before calling `launchTasks`. > > > > Also, please capture the parameter to the 'mount' and 'unmount' here to > > verify that it's the same as specified in ContainerInfo. OK, moved before `launchTasks`, one question is how can I verify this parameters? Did not found a good way to verify here. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131457 ----------------------------------------------------------- On 五月 3, 2016, 7:51 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46140/ > ----------------------------------------------------------- > > (Updated 五月 3, 2016, 7:51 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5266 > https://issues.apache.org/jira/browse/MESOS-5266 > > > Repository: mesos > > > Description > ------- > > Added test "ROOT_CommandTaskNoRootfsSingleVolume". > > > Diffs > ----- > > src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp > 070d52018e82ed3e46fb1b79714ffc4716f6a306 > src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46140/diff/ > > > Testing > ------- > > make > make check > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsSingleVolume" > --verbose > > > Thanks, > > Guangya Liu > >
