----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/#review129936 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp (lines 2041 - 2042) <https://reviews.apache.org/r/46323/#comment193488> const & for both of these since the rhs is not a temporary - Ben Mahler On April 21, 2016, 2:28 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46323/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 2:28 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4908 > https://issues.apache.org/jira/browse/MESOS-4908 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/internal/evolve.hpp cff6b657a6d69ff9e7f7dedc965122a03a200da1 > src/internal/evolve.cpp 4ca2abacd75523de8fb4ffe69a9edd8627f512af > src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 > src/slave/slave.hpp f78c1b4e4d5378ef7223c6eb3ea45491c30fb4c1 > src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553 > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb > src/tests/slave_tests.cpp ee58488b0b927c7c5833add4718941539663e6d2 > > Diff: https://reviews.apache.org/r/46323/diff/ > > > Testing > ------- > > The whole chain is tested in https://reviews.apache.org/r/46325/ > > > Thanks, > > Alexander Rukletsov > >
