----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46426/#review129756 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp (line 28) <https://reviews.apache.org/r/46426/#comment193296> I would just call it 'volumes' as Docker and Volume is in the directory path. I'll fix it for you. src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp (line 36) <https://reviews.apache.org/r/46426/#comment193292> This might polute the namespace (other places in the code might have 'getContainerDir' as well). Ok, i think we should put docker volume related stuff to a namespace 'mesos::internal::slave::docker::volume' I'll do the change for you. - Jie Yu On April 20, 2016, 5:41 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46426/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 5:41 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Added paths helper function for docker volume checkpoint. > > > Diffs > ----- > > src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed > src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac > src/slave/containerizer/mesos/isolators/docker/volume/paths.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/paths.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/46426/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
