> On 四月 5, 2016, 4:55 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, line 59 > > <https://reviews.apache.org/r/45360/diff/2/?file=1323003#file1323003line59> > > > > Do we need check `dvdcli` version or something first? > > Guangya Liu wrote: > The dvdcli currently only have one release and also planning to write a > C++ library for mesos, so I think that we do not need to check the version > now. What do you think? https://github.com/emccode/dvdcli/releases
I will add version check in `isolator::create` - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review127121 ----------------------------------------------------------- On 四月 15, 2016, 2:43 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45360/ > ----------------------------------------------------------- > > (Updated 四月 15, 2016, 2:43 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added volume driver client for mount and unmount. > > > Diffs > ----- > > src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 > src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/45360/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
