> On 四月 14, 2016, 6:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 72-73 > > <https://reviews.apache.org/r/46180/diff/4/?file=1344313#file1344313line72> > > > > How about moving "' used by volume isolator" to the second line?
I was now using `os::which`, so no need for this now. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review128942 ----------------------------------------------------------- On 四月 14, 2016, 1:40 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46180/ > ----------------------------------------------------------- > > (Updated 四月 14, 2016, 1:40 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented create() for docker volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/46180/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
