> On 四月 14, 2016, 10:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, line 19 > > <https://reviews.apache.org/r/45270/diff/7/?file=1343794#file1343794line19> > > > > Why this namespace? This is technically not 'spec', but the _state_ > > scheme used by the isolator. We should call the protobuf file 'state.proto'. > > > > I would suggest we still put it under `package mesos.internal.slave`, > > and call it `DockerVolumeMount`. > > > > s/ExternalMountList/DockerVolumeState/
what about putting this under `package mesos.internal.slave.volume`? > On 四月 14, 2016, 10:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, lines > > 21-35 > > <https://reviews.apache.org/r/45270/diff/7/?file=1343794#file1343794line21> > > > > Why do you need to checkpoint 'container_path', 'mount_point' and > > 'driver_options'? My original thought was adding more info here for debug, yes, we can remove them now. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/#review129011 ----------------------------------------------------------- On 四月 14, 2016, 4:41 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45270/ > ----------------------------------------------------------- > > (Updated 四月 14, 2016, 4:41 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Added spec protobut for external mount. > > > Diffs > ----- > > src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 > src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f > src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto > PRE-CREATION > > Diff: https://reviews.apache.org/r/45270/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
