-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46168/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Jiang Yan Xu.
Bugs: MESOS-5119
https://issues.apache.org/jira/browse/MESOS-5119
Repository: mesos
Description
-------
Add subdirectory support to URI.filename field.
URI.filename allows the user to specify the name of the file that will be saved
in the sandbox when the URI is fetched, but previously it would fail at fetch
time if "filename" had a directory component. This change allows users to
specify a relative path for custom filenames within the sandbox.
Diffs
-----
docs/fetcher.md fd6d8a78bd35c5644dceff7005dd7dfd9f5f2171
src/launcher/fetcher.cpp 47583eeaed53b3e7ed4db26fee7cdd2fae5e0c9d
src/slave/containerizer/fetcher.cpp d5910ad570371ba54580be5bb94344a1de38d1f9
src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e
src/tests/fetcher_tests.cpp 23a8dc5f4402c5613744753284aabbe3d09bf797
Diff: https://reviews.apache.org/r/46168/diff/
Testing
-------
Three tests were added. In fetcher_tests.cpp, CustomFilenameSubdirectory tests
that the fetcher creates a file in a specified subdirectory in the sandbox, and
AbsoluteCustomSubdirectoryFails tests that a custom filename with an absolute
path is rejected. In fetcher_cache_tests.cpp,
CachedCustomFilenameWithSubdirectory tests that the same behavior holds when
the URI is fetched from the cache.
Thanks,
Michael Browning
