The ack to the executor is done by the slave as soon as it checkpoints it.
@vinodkone > On Apr 13, 2016, at 7:17 AM, Qian Zhang <[email protected]> wrote: > > > >>> On April 13, 2016, 4:24 a.m., Vinod Kone wrote: >>> src/launcher/http_command_executor.cpp, lines 804-809 >>> <https://reviews.apache.org/r/44424/diff/8/?file=1338080#file1338080line804> >>> >>> Lets fix this hack now that the executor receives acknowledgements for >>> status updates. >>> >>> The executor can terminate after it receives an ACK for a terminal >>> status update. Can you add a TODO here and fix it in a separate review? >> >> Qian Zhang wrote: >> Agree, will post a separate patch for it soon. > > But what if framework does not cooperate? E.g., it does not send ACK when it > receives a terminal status update from executor. Then the executor will never > terminate? I think that may not be what we want ... > > > - Qian > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44424/#review128522 > ----------------------------------------------------------- > > >> On April 13, 2016, 5:13 p.m., Qian Zhang wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/44424/ >> ----------------------------------------------------------- >> >> (Updated April 13, 2016, 5:13 p.m.) >> >> >> Review request for mesos, Anand Mazumdar and Vinod Kone. >> >> >> Bugs: MESOS-3558 >> https://issues.apache.org/jira/browse/MESOS-3558 >> >> >> Repository: mesos >> >> >> Description >> ------- >> >> Updated http_command_executor.cpp to use v1 API. >> >> >> Diffs >> ----- >> >> src/launcher/http_command_executor.cpp PRE-CREATION >> >> Diff: https://reviews.apache.org/r/44424/diff/ >> >> >> Testing >> ------- >> >> make check >> >> >> Thanks, >> >> Qian Zhang >
