> On April 6, 2016, 12:18 a.m., Jiang Yan Xu wrote: > > src/tests/cluster.hpp, line 188 > > <https://reviews.apache.org/r/45689/diff/2/?file=1327107#file1327107line188> > > > > These are default initialized anyways but explicitness is good.
There is a non-default constructor and these had no list initialization or the direct initialization, so AFAICT they get a trivial initializer (ie. nothing). I made this change because the ``containerizer`` pointer ended up non-null and invalid. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45689/#review127259 ----------------------------------------------------------- On April 5, 2016, 11:41 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45689/ > ----------------------------------------------------------- > > (Updated April 5, 2016, 11:41 p.m.) > > > Review request for mesos, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > If Cluster::Slave::start() fails, make sure we don't crash in the > destructor. > > > Diffs > ----- > > src/tests/cluster.hpp 91d3998176115002ea22a0825b1aaaee3fe0d768 > src/tests/cluster.cpp eefc2fa55bca1ad6a53047046fa4f5996d5c3fef > > Diff: https://reviews.apache.org/r/45689/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > James Peach > >
