----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126917 -----------------------------------------------------------
Fix it, then Ship it! Thanks for taking this on! I'll fix remaining issues and commit this for you. docs/versioning.md (line 85) <https://reviews.apache.org/r/45033/#comment189997> Let's do it as part of #45660. support/mesos-style.py (line 101) <https://reviews.apache.org/r/45033/#comment189992> /All/Source code support/mesos-style.py (line 116) <https://reviews.apache.org/r/45033/#comment189995> S/Non printable/Non-printable support/mesos-style.py (lines 116 - 117) <https://reviews.apache.org/r/45033/#comment190015> How about a more consistent output? My suggestion is: ``` "{path}:{line_number}: Non-printable characters" " found at [{chars}]: \"{line}\"\n".format( ``` support/mesos-style.py (line 120) <https://reviews.apache.org/r/45033/#comment189998> Let's call it `offset` for consistency with L112. support/mesos-style.py (line 121) <https://reviews.apache.org/r/45033/#comment190013> let's `.rstrip` to remove the newline. - Alexander Rukletsov On April 4, 2016, 3:21 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 3:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > ------- > > This patch adds an addition check in mesos-style.pl to check > for non-printable characters. It scans .cpp, .hpp, .cc, .h > files and reports an error if non-printable characters exist. > > As part of this patch, two non-printable characters have been identified > in versioning.md (one in Line 85 and another in Line 96) and are corrected > accordingly. > > Note: Scanning .md files is skipped based on feedback from reviews. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > ----- > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > ------- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
